Additional documentation for holiday calendars #6840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| DatetimeIndex(start='7/1/2012', end='7/10/2012', | ||
| freq=CDay(calendar=cal)).to_pydatetime() | ||
| # Weekend and holidays are skipped | ||
| offset = CustomBusinessDay(calendar=cal) |
There was a problem hiding this comment.
split this up into multiple blocks (e.g. put separate ipython blocks where logical). You can the put the hash tagged text in their nicely. I find this a nice way to read docs.
|
@rockg sorry I think I canceled your Travis build instead of mine on accident. Could you retriggger the build with Sorry! |
|
I'm going to do another commit so no worries. |
|
ping when u r ready to merge |
…o start/end date logic.
|
@jreback Think I understood what you wanted regarding separate ipython blocks. Please take a look. Further, there was one bad piece of code that got in during the merge which I took out. |
|
beautiful! thanks |
jreback
added a commit
that referenced
this pull request
Apr 9, 2014
Additional documentation for holiday calendars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jreback here are the additional holiday examples. Let me know if you want something else.